This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Merged
Conversation
added 5 commits
October 21, 2022 15:44
- Remove "alternatively" from sole positional argument text - Unify writing for -app application/app id text - Fix typos
Contributor
|
I'd rather use the CWD for the yaml output and add a new parameter to give a specific target directory for the app config. |
Author
|
@langma so maybe something like this: This way the config.yaml is would be in the current working directory, unless you specify the |
langma
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation to PR #51
As the
deploycommand expects a directory, create aconfigdirectory for theconfig.yamlfile. This makes the first-developer experience even smoother. If the directory exist, the command exits. The file creation can be skipped using the--skip-create-fileflag.At the same go cleaned up some typos, improved flags help text writing and nicer app list formatting.