Skip to content

[SDKS-29]: Python Input Validation #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmelograno merged 1 commit into from
Sep 24, 2018
Merged

[SDKS-29]: Python Input Validation #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion splitio/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def track(self, key, traffic_type, event_type, value=None):
traffic_type = input_validator.validate_traffic_type(traffic_type)
value = input_validator.validate_value(value)

if key is None or event_type is None or traffic_type is None or value is None:
if key is None or event_type is None or traffic_type is None or value is False:
return False

event = Event(
Expand Down
4 changes: 2 additions & 2 deletions splitio/input_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,11 @@ def validate_value(value):
:return: value
:rtype: number|None
"""
if _check_not_null(value, 'value', 'track') is False:
if value is None:
return None
if not isinstance(value, Number) or isinstance(value, bool):
_LOGGER.error('track: value must be a number.')
return None
return False
return value


Expand Down
6 changes: 3 additions & 3 deletions splitio/tests/test_input_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,10 @@ def test_track_with_event_type_does_not_conform_reg_exp(self):
"expression [a-zA-Z0-9][-_\\.a-zA-Z0-9]{0,62}.")

def test_track_with_null_value(self):
self.assertEqual(False, self.client.track(
self.assertEqual(True, self.client.track(
"some_key", "traffic_type", "event_type", None))
self.logger_error \
.assert_called_once_with("track: value cannot be None.")
self.logger_error.assert_not_called()
self.logger_warning.assert_not_called()

def test_track_with_string_value(self):
self.assertEqual(False, self.client.track(
Expand Down
2 changes: 1 addition & 1 deletion splitio/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '6.0.0'
__version__ = '6.1.0'