Skip to content

[SDKS-128: GetTreatments #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmelograno merged 1 commit into from
Oct 12, 2018
Merged

[SDKS-128: GetTreatments #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion splitio/input_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ def validate_features_get_treatments(features):
if not isinstance(features, list):
_LOGGER.error('get_treatments: features must be a list.')
return None
filtered_features = set(filter(lambda x: x is not None, features))
filtered_features = set(filter(lambda x: x is not None and
_check_is_string(x, 'feature_name', 'get_treatments'), features))
if len(filtered_features) == 0:
_LOGGER.warning('get_treatments: features is an empty list or has None values.')
return filtered_features
12 changes: 12 additions & 0 deletions splitio/tests/test_get_treatments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,15 @@ def test_client_with_valid_none_and_repeated_features_and_valid_key(self):
self.assertEqual(results['some_feature'], 'control')
self.assertEqual(results['some_feature_2'], 'control')
self.assertEqual(results['get_treatments_test'], 'on')

def test_client_with_valid_none_invalid_and_repeated_features_and_valid_key(self):
features = ['some_feature', 'get_treatments_test', 'some_feature_2',
'some_feature', 'get_treatments_test', None, 'valid',
True, [], True]
results = self._split.get_treatments('valid', features)
self.assertIn('some_feature', results)
self.assertIn('some_feature_2', results)
self.assertIn('get_treatments_test', results)
self.assertEqual(results['some_feature'], 'control')
self.assertEqual(results['some_feature_2'], 'control')
self.assertEqual(results['get_treatments_test'], 'on')
5 changes: 5 additions & 0 deletions splitio/tests/test_input_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,3 +484,8 @@ def test_get_treatments_with_none_features(self):
self.logger_warning \
.assert_called_once_with("get_treatments: features is an empty "
"list or has None values.")

def test_get_treatments_with_invalid_type_of_features(self):
self.assertEqual({}, self.client.get_treatments("some_key", [True]))
self.logger_error \
.assert_called_once_with("get_treatments: feature_name True has to be of type string.")
2 changes: 1 addition & 1 deletion splitio/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '6.2.0-rc1'
__version__ = '6.2.0-rc2'