Include index name in OpenSearchVectorStore for similarity search #1435
Closed
inpink wants to merge 1 commit intospring-projects:mainfrom
Closed
Include index name in OpenSearchVectorStore for similarity search #1435inpink wants to merge 1 commit intospring-projects:mainfrom
inpink wants to merge 1 commit intospring-projects:mainfrom
Conversation
- Resolved issue where index name was not being sent during similaritySearch. - Updated similaritySearch method to include index in the SearchRequest. - Implemented a test to verify that documents can be added and retrieved from two different indices using separate OpenSearchVectorStore instances. Ensured that similarity search results are correctly returned for the respective indices.
d5fcb10 to
f68afb6
Compare
Member
|
Thanks, much appreciated!! Merged in 5431bdd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
When performing a similarity search with SearchRequest, the index name is not included.
This leads to a permission error when using roles restricted to specific indices in Opensearch.
Contents
The index was included for adding and deleting documents but not for search.
I added it to ensure correct behavior.
Test
Issue Link
close #885