Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Support for Eclipse Formatter plugins#32

Closed
letientai299 wants to merge 3 commits intosquare:mainfrom
letientai299:master
Closed

Support for Eclipse Formatter plugins#32
letientai299 wants to merge 3 commits intosquare:mainfrom
letientai299:master

Conversation

@letientai299
Copy link
Contributor

There're two advantages for adding an Eclipse configuration:

  • The coding style can be shared and using across a team use Eclipse, Intellij and Netbeans.
  • Intellij doesn't play well with non-javadoc comment. But in practice, we need that kind of comments to explain the background behind the code, something that helpful for maintainer, but can not be put into Javadoc. Eclipse Formatter handle this very well.

Known issues:

  • There're no porting version for SquareAndroid.xml, as I don't think it's necessary.
  • Line breaks between annotation and method is not kept.
// input
interface HttpBinService {
  @GET("/ip")
  MyCall<Ip> getIp();
}

// Intellij won't change it. But Eclipse Formatter will remove the line break.
interface HttpBinService {
  @GET("/ip") MyCall<Ip> getIp();
}

Also, see #31

Le Tien Tai added 3 commits March 29, 2016 14:06
- This is an adapted version for the default Square.xml, aim to be used with
  the Eclipse formatter plugin for Intellij Idea and Netbeans.
@letientai299
Copy link
Contributor Author

This has been there quite a long time. CC @JakeWharton for review and give decision.

@zach-klippenstein zach-klippenstein changed the base branch from master to main August 12, 2020 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant