Fix the model saving#10
Merged
r0mainK merged 1 commit intosrc-d:masterfrom Aug 16, 2018
r0mainK:fix/model
Merged
Conversation
Signed-off-by: Romain Keramitas <[email protected]>
kafkasl
approved these changes
Aug 16, 2018
Contributor
kafkasl
left a comment
There was a problem hiding this comment.
It works with the whole pipeline. I think asdf -> yaml do not support tuples out of the box.
Thanks for the help!
Contributor
Author
|
Okay great, merging then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to issue #9
So as I told you in slack @kafkasl the problem came from the
_path2indexand_path2indexdicts, which could be saved but when being loaded I think the keys were seen as lists which caused the error.Since the
_path2indexmapping is a one-to-one correspondence, I save this mapping instead:{index: (path, freq)}. Also I modified the dump function, it did not work as intended I think.
Anyway I test on dummy data, so if you could run the pipeline to check it works, then just tell me and we can merge this.