[Merged by Bors] - LDAP user authentication for Airflow#133
Closed
[Merged by Bors] - LDAP user authentication for Airflow#133
Conversation
sbernauer
reviewed
Jul 19, 2022
Member
sbernauer
left a comment
There was a problem hiding this comment.
LGTM, only minor comments.
Thanks for picking this up!
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
sbernauer
approved these changes
Jul 19, 2022
Member
sbernauer
left a comment
There was a problem hiding this comment.
Nice, thanks for your work!
Co-authored-by: Sebastian Bernauer <[email protected]>
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
# Description This PR covers the addition of LDAP user authentication to Airflow: the default `webserver_config.py` is now overwritten, allowing e.g. LDAP settings to be defined according to the CR. Closes #100.
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR covers the addition of LDAP user authentication to Airflow: the default
webserver_config.pyis now overwritten, allowing e.g. LDAP settings to be defined according to the CR.Closes #100.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information