Skip to content

[Merged by Bors] - Enable Log Aggregation for Airflow#219

Closed
siegfriedweber wants to merge 31 commits intomainfrom
logging
Closed

[Merged by Bors] - Enable Log Aggregation for Airflow#219
siegfriedweber wants to merge 31 commits intomainfrom
logging

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jan 20, 2023 •
edited
Loading

Description

Add log aggregation

Closes #213

TODOs before merging

  • Release operator-rs, upgrade to the new version and remove patch from Cargo.toml.
  • Remove repo: docker.stackable.tech/sandbox/logging from the integration tests.

Integration tests

Build Status

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber self-assigned this Jan 20, 2023
@siegfriedweber siegfriedweber changed the title wip Enable Log Aggregation for Airflow Jan 20, 2023
@siegfriedweber siegfriedweber mentioned this pull request Jan 20, 2023
Closed
@siegfriedweber siegfriedweber force-pushed the logging branch 6 times, most recently from 9ab8897 to a19cbee Compare January 25, 2023 10:53
@siegfriedweber siegfriedweber force-pushed the logging branch 2 times, most recently from ab92495 to 4bdec4b Compare January 26, 2023 09:57
@siegfriedweber siegfriedweber marked this pull request as ready for review February 2, 2023 16:37
maltesander
maltesander requested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.
The mount-dags-pvc test fails locally (not part of this PR) if the nodes are not labeled with 1..3.
We could do some refactoring to avoid code duplication.

This was referenced Feb 6, 2023
Closed
Closed
Closed
maltesander
maltesander approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass!

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Feb 6, 2023

bors merge

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@siegfriedweber
Enable Log Aggregation for Airflow (#219)
423834f 
# Description

Add log aggregation
@bors
Copy link

bors bot commented Feb 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable Log Aggregation for Airflow [Merged by Bors] - Enable Log Aggregation for Airflow Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
@bors bors bot deleted the logging branch February 6, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

release/23.4.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Log Aggregation for Airflow

3 participants

@siegfriedweber @maltesander @lfrancke