Skip to content

[Merged by Bors] - Add missing crd defaults#277

Closed
maltesander wants to merge 2 commits intomainfrom
add-missing-crd-defaults
Closed

[Merged by Bors] - Add missing crd defaults#277
maltesander wants to merge 2 commits intomainfrom
add-missing-crd-defaults

Conversation

@maltesander
Copy link
Member

Description

Due to breaking changes in with the clusterConfig the CRD replace still works but the operator throws an error:

2023-05-12T08:51:04.696282Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="airflowcluster.airflow.stackable.tech" error=event queue error error.sources=[fa
iled to perform initial object list: Error deserializing response, Error deserializing response, missing field `credentialsSecret` at line 1 column 5264]

This will be gone when applying a new correct CR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 12, 2023
# Description

Due to breaking changes in with the clusterConfig the CRD replace still works but the operator throws an error:
```
2023-05-12T08:51:04.696282Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="airflowcluster.airflow.stackable.tech" error=event queue error error.sources=[fa
iled to perform initial object list: Error deserializing response, Error deserializing response, missing field `credentialsSecret` at line 1 column 5264]
```
This will be gone when applying a new correct CR.



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link

bors bot commented May 12, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Add missing crd defaults [Merged by Bors] - Add missing crd defaults May 12, 2023
@bors bors bot closed this May 12, 2023
@bors bors bot deleted the add-missing-crd-defaults branch May 12, 2023 14:27
maltesander added a commit that referenced this pull request May 12, 2023
# Description

Due to breaking changes in with the clusterConfig the CRD replace still works but the operator throws an error:
```
2023-05-12T08:51:04.696282Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="airflowcluster.airflow.stackable.tech" error=event queue error error.sources=[fa
iled to perform initial object list: Error deserializing response, Error deserializing response, missing field `credentialsSecret` at line 1 column 5264]
```
This will be gone when applying a new correct CR.

Co-authored-by: Malte Sander <[email protected]>

(cherry picked from commit 4308923)
@razvan razvan mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants