Skip to content

Consolidate authentication config in CRD#303

Merged
maltesander merged 12 commits intomainfrom
consolidate_authentication_config
Jul 26, 2023
Merged

Consolidate authentication config in CRD#303
maltesander merged 12 commits intomainfrom
consolidate_authentication_config

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Jul 24, 2023 •
edited by adwk67
Loading

Description

fixes #298

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/94/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [x] Code contains useful comments
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels Jul 24, 2023
@maltesander maltesander self-assigned this Jul 24, 2023
@maltesander maltesander marked this pull request as ready for review July 24, 2023 15:01
@maltesander maltesander requested a review from a team July 24, 2023 15:02
@adwk67 adwk67 requested review from adwk67 and removed request for a team July 25, 2023 15:02
@adwk67 adwk67 self-assigned this Jul 25, 2023
adwk67
adwk67 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maltesander maltesander requested a review from adwk67 July 26, 2023 09:59
adwk67
adwk67 previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander
Copy link
Member Author

maltesander commented Jul 26, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jul 26, 2023
@maltesander
Consolidate authentication config in CRD (#303)
dcc5796 
# Description

fixes #298

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/94/



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link

bors bot commented Jul 26, 2023

Build failed:

@maltesander
Copy link
Member Author

maltesander commented Jul 26, 2023

bors retry

@bors
Copy link

bors bot commented Jul 26, 2023

👎 Rejected by too few approved reviews

@maltesander maltesander added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 2d7a5ab Jul 26, 2023
@maltesander maltesander deleted the consolidate_authentication_config branch July 26, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@adwk67 adwk67

@maltesander maltesander

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rework Airflow TLS / Auth structs: Change authentication to list of AuthenticationClasses

2 participants

@maltesander @adwk67