Skip to content

chore: add overrides integrationtests#490

Merged
razvan merged 13 commits intomainfrom
chore/add-hint-for-pod-template
Aug 26, 2024
Merged

chore: add overrides integrationtests#490
razvan merged 13 commits intomainfrom
chore/add-hint-for-pod-template

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Aug 12, 2024

Description

Adding a caution hint for changing the pod template variable after pod overrides are already applied.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@xeniape xeniape changed the title chore: add hint for pod template chore: recapture pod_template to immutable after applying overrides Aug 13, 2024
@xeniape xeniape mentioned this pull request Aug 13, 2024
Closed
17 tasks
@xeniape xeniape changed the title chore: recapture pod_template to immutable after applying overrides chore: add overrides integrationtests Aug 20, 2024
@xeniape xeniape self-assigned this Aug 22, 2024
@razvan razvan enabled auto-merge August 26, 2024 16:36
@razvan razvan added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 5cb377b Aug 26, 2024
@razvan razvan deleted the chore/add-hint-for-pod-template branch August 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

@xeniape xeniape

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xeniape @razvan