[Merged by Bors] - Add missing crd defaults#360
Closed
maltesander wants to merge 2 commits intomainfrom
Closed
Conversation
12 tasks
Contributor
|
It won't magically migrate old objects that are no longer legal, but it will let users write back an updated CR object. |
nightkr
approved these changes
May 12, 2023
Maleware
approved these changes
May 12, 2023
Member
Maleware
left a comment
There was a problem hiding this comment.
LGTM tested on IONOS cluster.
Steps:
- Install 23.1
- Installed example for hbase
k replacethe new crd from the PR -> Error- helm upgrade to new operator version
- k apply updated example
=> Error gone
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 12, 2023
# Description Due to breaking changes in with the `clusterConfig` the CRD replace still works but the operator throws an error: ``` 2023-05-12T08:27:57.068053Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="hbasecluster.hbase.stackable.com" error=event queue error error.sources=[failed to perform initial object list: Error deserializing response, Error deserializing response, missing field `zookeeperConfigMapName` at line 1 column 5778] ``` This will be gone when applying a new correct CR. Co-authored-by: Malte Sander <[email protected]>
Contributor
|
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
maltesander
added a commit
that referenced
this pull request
May 12, 2023
(cherry picked from commit 45f1040)
bors bot
pushed a commit
that referenced
this pull request
May 15, 2023
# Description Add missing crd defaults (#360) (cherry picked from commit 45f1040) Co-authored-by: Malte Sander <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to breaking changes in with the
clusterConfigthe CRD replace still works but the operator throws an error:This will be gone when applying a new correct CR.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information