Skip to content

chore: advertise restserver in rolegroup configmap#708

Merged
xeniape merged 3 commits intomainfrom
feat/advertise-restserver
Nov 10, 2025
Merged

chore: advertise restserver in rolegroup configmap#708
xeniape merged 3 commits intomainfrom
feat/advertise-restserver

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Nov 7, 2025 •
edited by adwk67
Loading

Description

Implementation of #669

Adds

  • hbase.rest.hostname
  • hbase.rest.port
  • hbase.rest.info.port

properties to the restserver rolegroup configmap. hbase.rest.hostname and hbase.rest.info.port are not pre-existing hbase-site.xml keys, but were added with a similar naming scheme as master properties.

Advertisement of restservers was done to be consistent with master and regionserver advertisement.

Note

(also added to the issue)
Added by @adwk67 The aim here is not to implement full discoverability for role endpoints; that should be done when we tackle that for all operators. We actually reached a point in the original implementation of HBase listener-endpoints where there was a config map (like kafka, hdfs etc.) that listed the endpoints by pod/replica, and at that point we decided against doing that as

  • it would have been premature without knowing what discovery-2.0 would look like in general (naming, structure etc.), and
  • we didn't want to implement and advertise something that could then become a breaking change later on.

So I understand the scope of this ticket to be about bringing the rest-server inline with the other roles, without claiming this to be the final destination.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Nov 7, 2025
@xeniape xeniape changed the title feat: advertise restserver in rolegroup configmap chore: advertise restserver in rolegroup configmap Nov 7, 2025
@xeniape xeniape marked this pull request as ready for review November 7, 2025 14:27
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Nov 7, 2025
@maltesander maltesander self-requested a review November 10, 2025 07:06
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 10, 2025
maltesander
maltesander approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xeniape xeniape added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit a152f08 Nov 10, 2025
17 checks passed
@xeniape xeniape deleted the feat/advertise-restserver branch November 10, 2025 12:41
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Nov 10, 2025
@xeniape xeniape linked an issue Nov 10, 2025 that may be closed by this pull request
Restservers aren't advertised? #669
Closed
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Nov 11, 2025
@lfrancke
Copy link
Member

lfrancke commented Nov 11, 2025

This is not in 25.11, correct?
Could you please add release notes?

@xeniape
Copy link
Member Author

xeniape commented Nov 17, 2025 •
edited
Loading

This is not in 25.11, correct? Could you please add release notes?

No, not in 25.11

Release Note

Add hbase.rest.hostname, hbase.rest.port, and hbase.rest.info.port values to the restserver rolegroup configmap for advertising the restservers in the same way as master and regionservers.

Adjusted Release Note in #716 (comment)

@xeniape xeniape added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 17, 2025
This was referenced Nov 17, 2025
Closed
Merged
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Nov 19, 2025
@xeniape xeniape removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@xeniape xeniape

Labels

release/26.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restservers aren't advertised?

3 participants

@xeniape @lfrancke @maltesander