Skip to content

fix: remove role binding to legacy service account name#1060

Merged
razvan merged 5 commits intomainfrom
issues/1005
Jun 24, 2025
Merged

fix: remove role binding to legacy service account name#1060
razvan merged 5 commits intomainfrom
issues/1005

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jun 19, 2025

Description

Fixes #1005

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@razvan razvan self-assigned this Jun 19, 2025
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 19, 2025
@razvan razvan requested a review from a team June 19, 2025 12:13
@razvan razvan mentioned this pull request Jun 19, 2025
Merged
20 tasks
nightkr
nightkr reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@nightkr nightkr moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 24, 2025
@razvan razvan requested a review from nightkr June 24, 2025 13:10
@razvan razvan enabled auto-merge June 24, 2025 13:11
@razvan razvan added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 7d5a43e Jun 24, 2025
8 checks passed
@razvan razvan deleted the issues/1005 branch June 24, 2025 13:23
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jun 30, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 30, 2025
@lfrancke
Copy link
Member

lfrancke commented Jun 30, 2025

Should this appear in the release notes?

@razvan
Copy link
Member Author

razvan commented Jun 30, 2025

Release Notes

This release removes support for previously deprecated product service accounts. Deprecated service accounts named {product_name}-serviceaccount are ignored. Instead, product workloads use service accounts named
{resource_name}-serviceaccount where resource_name is the stacklet (or cluster) name as defined in the cluster resource.

@razvan razvan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 30, 2025
@razvan
Copy link
Member Author

razvan commented Jun 30, 2025

Should this appear in the release notes?

added RN

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nightkr nightkr nightkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@razvan razvan

Labels

release/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove legacy rolebinding from build_rbac_resources

4 participants

@razvan @lfrancke @nightkr @sbernauer