fix(stackable-versioned): Emit correct match arms for version enum#1065
Merged
fix(stackable-versioned): Emit correct match arms for version enum#1065
Conversation
sbernauer
reviewed
Jun 26, 2025
sbernauer
approved these changes
Jun 26, 2025
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is rather curious because the previous generated code should result in compiler errors. The expanded code does not error, but manually copy+pasting the generated code reveals the compiler error as expected:
The incorrect match resulted in
as_strto always return the earliest version (usuallyv1alpha1). This resulted in the wrong version to be marked as stored when callingFoo::merged_crd.