Skip to content

fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes#708

Merged
sbernauer merged 3 commits intomainfrom
fix/ldap-tls-volumes
Jan 4, 2024
Merged

fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes#708
sbernauer merged 3 commits intomainfrom
fix/ldap-tls-volumes

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 4, 2024 •
edited by NickLarsenNZ
Loading

Description

Noticed in stackabletech/airflow-operator#366

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also ad… fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also add the needed TLS volumes Jan 4, 2024
@sbernauer sbernauer changed the title fix: Let ldap::AuthenticationProvider::add_volumes_and_mounts also add the needed TLS volumes fix: Let ldap add_volumes_and_mounts also add the needed TLS volumes Jan 4, 2024
fhennig
fhennig approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 8320525 Jan 4, 2024
@sbernauer sbernauer deleted the fix/ldap-tls-volumes branch January 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fhennig fhennig fhennig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @fhennig