[Merged by Bors] - Implement unprivileged mode#252
Closed
Conversation
Contributor
Author
|
It has been ok'd by @lfrancke, so ready for review. |
sbernauer
approved these changes
Mar 27, 2023
Member
sbernauer
left a comment
There was a problem hiding this comment.
Tested using helm install secret-operator stackable-test/secret-operator --version 0.0.0-pr252 --set securityContext.privileged=false
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
# Description This adds support for running as an unprivileged container (mostly fixes #243). Sadly, it doesn't run rootless per se, since we need those privileges to register the CSI plugins, but it at least lets containerd/k8s keep some of its sandboxing.
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for running as an unprivileged container (mostly fixes #243).
Sadly, it doesn't run rootless per se, since we need those privileges to register the CSI plugins, but it at least lets containerd/k8s keep some of its sandboxing.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information