This repository was archived by the owner on Feb 16, 2024. It is now read-only.
[Merged by Bors] - Fix bug that prevents deserializing stacks and demos using serde_yaml 0.9#103
Closed
[Merged by Bors] - Fix bug that prevents deserializing stacks and demos using serde_yaml 0.9#103
Conversation
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
… 0.9 (#103) ## Description With `serde_yaml` 0.9 a bug was introduced that stopped us from parsing stacks and demos. ``` cargo r -- demo list Finished dev [unoptimized + debuginfo] target(s) in 0.05s Running `target/debug/stackablectl demo list` [WARN ] Failed to parse demo list from https://raw.githubusercontent.com/stackabletech/stackablectl/main/demos/demos-v1.yaml: demos.trino-taxi-data.manifests[0]: invalid type: map, expected a YAML tag starting with '!' at line 14 column 9 ``` This PR fixes this ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
serde_yaml0.9 a bug was introduced that stopped us from parsing stacks and demos.This PR fixes this
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information