Skip to content

[Merged by Bors] - Logging#588

Closed
siegfriedweber wants to merge 46 commits intomainfrom
logging
Closed

[Merged by Bors] - Logging#588
siegfriedweber wants to merge 46 commits intomainfrom
logging

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Nov 15, 2022 •
edited
Loading

Description

Add logging configuration and start a Vector log agent to collect the logs and forward them to a log aggregator.

Closes stackabletech/issues#295

TODOs before merging:

  • tests/templates/kuttl/logging/01-install-zookeeper.yaml.j2, tests/templates/kuttl/delete-rolegroup/00-install-zookeeper.yaml.j2, tests/templates/kuttl/smoke/00-install-zookeeper.yaml.j2, and tests/templates/kuttl/znode/00-install-zookeeper.yaml.j2: Remove repo: docker.stackable.tech/sandbox/logging when Logging docker-images#268 is merged and the images are built and deployed.
  • Use released version of operator-rs.

Integration tests

Build Status

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber self-assigned this Nov 15, 2022
@siegfriedweber siegfriedweber mentioned this pull request Nov 15, 2022
Closed
28 tasks
@siegfriedweber siegfriedweber force-pushed the logging branch 2 times, most recently from 7bd23d7 to 76c97f3 Compare November 21, 2022 12:12
@siegfriedweber siegfriedweber force-pushed the logging branch 2 times, most recently from 543dffa to ea0e0bb Compare December 5, 2022 10:51
@siegfriedweber
Add Vector agent as sidecar container
c65bc3d
@siegfriedweber
Extend logging configuration
a701414
@siegfriedweber
Start Vector from the ZooKeeper image
e43710a
@siegfriedweber
Fix multiline detection in the Vector configuration
c45d7b9
@siegfriedweber
Gather logs from the init container
b5d3a86
@siegfriedweber
Forward Vector logs to the aggregator
1b9d9a3
@siegfriedweber
Allow setting the log level per logger
a41093b
@siegfriedweber
Rename log level OFF to NONE
8c11c05
@siegfriedweber
Use the configured log level threshold of Vector
23b5c71
@siegfriedweber
Use a fragment for the ZookeeperConfig
5b20f22
@siegfriedweber
Translate log level NONE to OFF in logback
dbbe4bc
@siegfriedweber
Use configured log level also for shell script output
3d14877
@siegfriedweber
Add log4j configuration
d35301f
@siegfriedweber
Add missing serde(default) annotation
98224de
@siegfriedweber
Move logging structs and functions to operator-rs
1c8b0f0
@siegfriedweber
Use the vector container built by the framework
282d0c7
@siegfriedweber
Use Vector config file name from the framework
535b194
@siegfriedweber
Allow custom log configuration
7f12047
@siegfriedweber
Regenerate charts
175f194
@siegfriedweber
Update operator-rs
d11d4c4
@siegfriedweber
Fix rebase error
f0cf9cd
@siegfriedweber
Add logging tests
954fb33
@siegfriedweber
Rename "levelThreshold" to "level"
5a2ed58
@maltesander maltesander mentioned this pull request Dec 15, 2022
Closed
sbernauer
sbernauer reviewed Dec 16, 2022
View reviewed changes
sbernauer
sbernauer approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please change to released operator-rs version before merging

sbernauer
sbernauer approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to be merged

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Dec 19, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 19, 2022
@siegfriedweber
Logging (#588)
512255c 
# Description

Add logging configuration and start a Vector log agent to collect the logs and forward them to a log aggregator.
@bors
Copy link
Contributor

bors bot commented Dec 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Logging [Merged by Bors] - Logging Dec 19, 2022
@bors bors bot closed this Dec 19, 2022
@bors bors bot deleted the logging branch December 19, 2022 07:33
@maltesander maltesander mentioned this pull request Dec 19, 2022
Open
6 tasks
@fhennig fhennig mentioned this pull request Dec 19, 2022
Closed
6 tasks
@lfrancke
Copy link
Member

lfrancke commented Dec 20, 2022

Added to the feature tracker

@lfrancke lfrancke mentioned this pull request Dec 23, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@siegfriedweber siegfriedweber

@sbernauer sbernauer

Labels

release/23.1.0 type/feature-new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vector Logging Spike with sidecar & reading from files

3 participants

@siegfriedweber @lfrancke @sbernauer