Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c3ba522fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def parse_timestamp(raw_value: str) -> datetime: | ||
| return datetime.fromisoformat(raw_value.replace("Z", "+00:00")).astimezone(UTC) |
There was a problem hiding this comment.
Reject naive timestamps to keep dedup deterministic
parse_timestamp accepts timezone-naive strings and immediately calls astimezone(UTC), which makes Python interpret them in the host's local timezone. If a user provides hits like "2026-03-18T10:01:00" (no offset), the same input file can produce different normalized times and suppression outcomes across environments (especially around DST boundaries), contradicting the demo’s deterministic/reproducible behavior. This parser should either require an explicit offset/Z or attach UTC explicitly before conversion.
Useful? React with 👍 / 👎.
What changed
rule-evaluation-and-dedup-demoas a third small, file-based demotelemetry-labreads as a three-demo repositoryValidation
python -m pytestpython -m telemetry_window_demo.cli run-rule-dedup-demo