ROX-9833: Fixing parsing comparator default criteria value regression#1040
Merged
pedrottimark merged 8 commits intomasterfrom Mar 23, 2022
Merged
ROX-9833: Fixing parsing comparator default criteria value regression#1040pedrottimark merged 8 commits intomasterfrom
pedrottimark merged 8 commits intomasterfrom
Conversation
|
Tag for build #339021 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.69.x-179-g2099c023f3'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.69.x-179-g2099c023f3 central generate interactive > bundle.zip🕹️ A |
pedrottimark
approved these changes
Mar 23, 2022
parametalol
pushed a commit
that referenced
this pull request
Mar 23, 2022
RTann
pushed a commit
that referenced
this pull request
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses the comparator default criteria value regression for default policies with a space in the value string, e.g.
>= IMPORTANTvs>=IMPORTANTby sending the default policy sections for default policies instead of the parsed/formatted version of policy sections that would remove the space.It also addresses an issue with Exposed Node Export where the input was set to
numberinstead oftextand the changes to PF caused the string values to not render in the number input.It also removes the feature flag in the Violations page policy details tab.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.