Conversation
|
Tag for build #353525 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.69.x-213-g8a7f46a650'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.69.x-213-g8a7f46a650 central generate interactive > bundle.zip🕹️ A |
SimonBaeumer
left a comment
There was a problem hiding this comment.
Approving to not block the merge as the change works.
Please check if it is possible to avoid this in the data layer (also okay to defer to another PR imho).
|
|
||
| regs := rs.getRegistries(namespace) | ||
| err = regs.UpdateImageIntegration(&storage.ImageIntegration{ | ||
| Id: registry, |
There was a problem hiding this comment.
I recommend letting UpdateImageIntegration set the registry as the ID automatically or validating it before persisting to avoid saving corrupted integrations.
There was a problem hiding this comment.
This is called in other places where the ID is already populated as a UUID. This is a case where we dont want to use a UUID because of how it's used. I think this is ok
Description
Image Integrations in Sensor lacked an ID, so it was not indexed properly. Unit tests for the secret listener missed this.
Use the registry's name as the ID because that is how it is indexed in the dockercfg secret.
Checklist
[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade steps[ ] Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)Testing Performed
CI. Without this fix, these tests fail.