tests: TestTLSChallenge improvements#12305
Conversation
|
Images are ready for the commit at 704d97d. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12305 +/- ##
=======================================
Coverage 48.27% 48.27%
=======================================
Files 2402 2402
Lines 171570 171571 +1
=======================================
+ Hits 82819 82820 +1
Misses 82064 82064
Partials 6687 6687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest-times 7 gke-nongroovy-e2e-tests |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
/test gke-nongroovy-e2e-tests |
|
/test ocp-4-12-nongroovy-e2e-tests |
|
/test gke-nongroovy-e2e-tests |
3 similar comments
|
/test gke-nongroovy-e2e-tests |
|
/test gke-nongroovy-e2e-tests |
|
/test gke-nongroovy-e2e-tests |
|
/test gke-nongroovy-e2e-tests |
1 similar comment
|
/test gke-nongroovy-e2e-tests |
|
/test ocp-4-12-nongroovy-e2e-tests |
704d97d to
267a717
Compare
|
Images are ready for the commit at 1cce8dd. To use with deploy scripts, first |
|
/test ocp-4-12-nongroovy-e2e-tests |
|
/test ocp-4-16-nongroovy-e2e-tests |
|
/test ocp-4-12-nongroovy-e2e-tests |
|
/test ocp-4-16-nongroovy-e2e-tests |
|
/test ocp-4-12-nongroovy-e2e-tests |
|
/test ocp-4-16-nongroovy-e2e-tests |
|
/retest |
|
Images are ready for the commit at e6b60e6. To use with deploy scripts, first |
1cce8dd to
e6b60e6
Compare
|
/retest-times 7 gke-nongroovy-e2e-tests |
|
/test gke-nongroovy-e2e-tests |
|
@porridge: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test ocp-4-12-nongroovy-e2e-tests |
|
/retest |
Description
In this flake the nginx image for the proxy failed to pull due to
unauthorized: access to the requested resource is not authorized. Upon inspection, thedefaultservice account was lacking the necessary image pull secret reference (which the test did patch in on setup).I don't know if this means it does the patching in a wrong way, which becomes a no-op in some corner case, or some other operation reverted its patch somehow (though the only write operation I see in the audit log was token subresource creation by the kubelet). I asked for some advice since this really puzzles me.
Either way, this method seems unreliable, so I'm changing it to an explicit reference to the pull secret in the pod template, which has the additional benefit of being a bit quicker.
mustGetEnvthat shouts if an env variable isn't presentproxyNsconst directlycommon*.gobecause it's not that simple.User-facing documentation
Testing and quality
Automated testing
How I validated my change