Skip to content

ROX-28296: reencrypt route operator integration#14771

Merged
stehessel merged 20 commits intomasterfrom
ROX-28296/operator-integration
Apr 16, 2025
Merged

ROX-28296: reencrypt route operator integration#14771
stehessel merged 20 commits intomasterfrom
ROX-28296/operator-integration

Conversation

@stehessel
Copy link
Copy Markdown
Collaborator

@stehessel stehessel commented Mar 26, 2025 •
edited
Loading

Description

Add the reencrypt route that was introduced in #14416 to the operator CRD.

  • If destinationCACertificate is set it should use this value.
  • If destinationCACertificate is not set, we default to the CA defined in central-tls.
SCR-20250415-nojj

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Installed the operator from catalog source and tested installation with and without custom destination CA.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 26, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stehessel stehessel force-pushed the ROX-28296/operator-integration branch from 4d4043a to 1770397 Compare March 26, 2025 16:43
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 26, 2025 •
edited
Loading

Images are ready for the commit at 6f58aca.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-467-g6f58aca4ed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 48.95%. Comparing base (eded5b5) to head (6f58aca).
Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
operator/internal/route/translation.go 84.61% 4 Missing and 2 partials ⚠️
...internal/central/values/translation/translation.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14771      +/-   ##
==========================================
- Coverage   48.96%   48.95%   -0.02%     
==========================================
  Files        2550     2550              
  Lines      187233   187213      -20     
==========================================
- Hits        91687    91652      -35     
- Misses      88298    88318      +20     
+ Partials     7248     7243       -5
Flag Coverage Δ
go-unit-tests 48.95% <85.48%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stehessel stehessel force-pushed the hack/ocp-reencrypt-route branch from ee2d7c0 to 1426ef3 Compare April 1, 2025 11:24
Base automatically changed from hack/ocp-reencrypt-route to master April 1, 2025 16:28
@stehessel stehessel force-pushed the ROX-28296/operator-integration branch 4 times, most recently from 81f124e to 79f4b15 Compare April 3, 2025 14:23
@stehessel
Copy link
Copy Markdown
Collaborator Author

stehessel commented Apr 3, 2025

/test all

@stehessel stehessel force-pushed the ROX-28296/operator-integration branch 9 times, most recently from ae9b43a to b71830f Compare April 7, 2025 08:46
@stehessel stehessel marked this pull request as ready for review April 7, 2025 08:49
@stehessel stehessel requested a review from a team as a code owner April 7, 2025 08:49
@stehessel stehessel requested review from GrimmiMeloni and removed request for a team April 7, 2025 08:49
@stehessel stehessel force-pushed the ROX-28296/operator-integration branch 3 times, most recently from fec77dc to 2777f90 Compare April 8, 2025 11:22
@stehessel stehessel force-pushed the ROX-28296/operator-integration branch from 2777f90 to ce18672 Compare April 10, 2025 09:01
porridge
porridge reviewed Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for such a full-featured PR, with tests and all. ❤️
Some nitpicks inline, also I think the injector will need some changes w.r.t. how we do caching.

stehessel and others added 12 commits April 10, 2025 14:34
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
0afbf20 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
75f861f 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
0c9e640 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
3c58fc6 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
1b0e796 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
817a9c0 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
060468c 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
ae95a72 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
883cb4a 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel @porridge
Update operator/api/v1alpha1/central_types.go
caaf8bd 
Co-authored-by: Marcin Owsiany <[email protected]>
@stehessel
address comments
65671f0
@stehessel
use utils.GetWithFallbackToUncached
e74a7e4
@stehessel stehessel force-pushed the ROX-28296/operator-integration branch from 82c5042 to e74a7e4 Compare April 10, 2025 13:18
@stehessel stehessel requested a review from porridge April 11, 2025 06:57
@stehessel
Copy link
Copy Markdown
Collaborator Author

stehessel commented Apr 15, 2025

/retest

porridge
porridge approved these changes Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks inline, LGTM otherwise.
Can you please update the screenshot and make sure it looks OK before merging?

@stehessel stehessel merged commit c23c2f7 into master Apr 16, 2025
89 checks passed
@stehessel stehessel deleted the ROX-28296/operator-integration branch April 16, 2025 09:06
janisz pushed a commit that referenced this pull request Apr 23, 2025
@stehessel @porridge @janisz
ROX-28296: reencrypt route operator integration (#14771)
56f522e 
Co-authored-by: Marcin Owsiany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes

@GrimmiMeloni GrimmiMeloni Awaiting requested review from GrimmiMeloni GrimmiMeloni is a code owner automatically assigned from stackrox/install

Assignees

No one assigned

Labels

area/operator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stehessel @rhacs-bot @porridge