-
Notifications
You must be signed in to change notification settings - Fork 172
ROX-33561: Migrate roxctl to ubi8-micro #19379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1c2c34f
64bb7de
df87a40
7e9278a
7fcc549
172a649
100c408
7c5aa46
586c990
56b0348
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,15 +26,33 @@ RUN RACE=0 CGO_ENABLED=1 GOOS=linux GOARCH=$(go env GOARCH) scripts/go-build.sh | |
| cp bin/linux_$(go env GOARCH)/roxctl image/bin/roxctl | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| FROM registry.access.redhat.com/ubi8/ubi-minimal:latest@sha256:5dc6ba426ccbeb3954ead6b015f36b4a2d22320e5b356b074198d08422464ed2 | ||
| FROM registry.access.redhat.com/ubi8/ubi-micro:latest@sha256:37552f11d3b39b3360f7be7c13f6a617e468f39be915cd4f8c8a8531ffc9d43d AS ubi-micro-base | ||
|
|
||
| COPY --from=builder /go/src/github.com/stackrox/rox/app/image/bin/roxctl /usr/bin/roxctl | ||
|
|
||
| RUN microdnf clean all && \ | ||
| rpm --verbose -e --nodeps $(rpm -qa curl '*rpm*' '*dnf*' '*libsolv*' '*hawkey*' 'yum*') && \ | ||
| rm -rf /var/cache/dnf /var/cache/yum | ||
| FROM registry.access.redhat.com/ubi8/ubi:latest@sha256:627867e53ad6846afba2dfbf5cef1d54c868a9025633ef0afd546278d4654eac AS package_installer | ||
|
|
||
| COPY LICENSE /licenses/LICENSE | ||
| # Copy ubi-micro base to /out/ to preserve its rpmdb | ||
| COPY --from=ubi-micro-base / /out/ | ||
|
|
||
| # Install packages directly to /out/ using --installroot | ||
| # Note: --setopt=reposdir=/etc/yum.repos.d instructs dnf to use repo configurations pointing to RPMs | ||
| # prefetched by Hermeto/Cachi2, instead of installroot's default UBI repos. | ||
| RUN dnf install -y \ | ||
| --installroot=/out/ \ | ||
| --releasever=8 \ | ||
| --setopt=install_weak_deps=False \ | ||
| --setopt=reposdir=/etc/yum.repos.d \ | ||
| --nodocs \ | ||
| ca-certificates && \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about openssl? We definitely need it for FIPS. |
||
| dnf clean all --installroot=/out/ && \ | ||
| rm -rf /out/var/cache/* | ||
|
|
||
| COPY --from=builder /go/src/github.com/stackrox/rox/app/image/bin/roxctl /out/usr/bin/roxctl | ||
| COPY LICENSE /out/licenses/LICENSE | ||
|
|
||
| FROM ubi-micro-base | ||
janisz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| COPY --from=package_installer /out/ / | ||
|
|
||
| ARG BUILD_TAG | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,8 @@ packages: | |
| - postgresql | ||
| # builder stage in operator/konflux.bundle.Dockerfile | ||
| - python3.12-pyyaml | ||
| # package_installer stages in image/roxctl/konflux.Dockerfile | ||
| - ca-certificates | ||
|
Comment on lines
+12
to
+13
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ca-certificates and openssl will be needed in all ubi-micro-s, so the comment should be revised. |
||
| moduleEnable: | ||
| # final stage in image/rhel/konflux.Dockerfile | ||
| - postgresql:15 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False.
dev-package-managersshould not be required any more.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#19485