ROX-33768: Add no-non-deprecated-reselect lint rule with ignores#19581
Conversation
|
Images are ready for the commit at d7bc382. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19581 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 2735 2735
Lines 206138 206138
=======================================
+ Hits 101538 101542 +4
+ Misses 97052 97048 -4
Partials 7548 7548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Objective
When we delete deprecated container folders, we intend to delete obsolete dependencies.
Problem
If non-deprecated files still depend on the dependencies (pardon pun) any additional unplanned technical investment might block deletion, because the effort will compete with other unplanned tasks.
Analysis
Find in Files
connect(has 15 results in 14 files.Although we keep
'react-redux'dependency, replace this obsolete pattern.from 'reselect'has 15 results in 15 files.Solution
Use typescript-eslint playground to understand
import { … } from 'reselect';statement.https://typescript-eslint.io/play/#ts=5.9.3&showAST=es&fileType=.tsx
Adapt from no-non-deprecated-PropTypes added in #19548
Edit pluginLimited.js file.
no-non-deprecated-connectlint rule.no-non-deprecated-reselectlint rule.Edit eslint.config.js file.
ignoresarray and comments.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.With configuration object but without
ignoresproperty see expected errors.