Skip to content

ROX-33770: Replace PropTypes in KeepBothSection component #19583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrottimark merged 1 commit into from
Mar 26, 2026
Merged

ROX-33770: Replace PropTypes in KeepBothSection component #19583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/apps/platform/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,6 @@ module.exports = [
'src/Containers/Login/LoginPage.jsx', // rewrite in TypeScript
'src/Containers/Login/TestLoginResultsPage.jsx', // rewrite in TypeScript
'src/Containers/MainPage/Header/UserMenu.tsx', // rewritten in TypeScript
'src/Containers/Policies/Modal/KeepBothSection.tsx', // rewritten in TypeScript
'src/Containers/Risk/EventTimeline/**', // deprecated
'src/Containers/Risk/Process/Binaries.jsx', // rewrite in TypeScript?
'src/Containers/Risk/Process/BinaryCollapsible.jsx', // rewrite in TypeScript?
Expand Down
11 changes: 5 additions & 6 deletions ui/apps/platform/src/Containers/Policies/Modal/KeepBothSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import PropTypes from 'prop-types';
import { Field } from 'formik';
import { Radio } from '@patternfly/react-core';

const KeepBothSection = ({ changeRadio }) => {
export type KeepBothSectionProps = {
changeRadio: (handler, name: string, value: string) => () => void;
};

const KeepBothSection = ({ changeRadio }: KeepBothSectionProps) => {
return (
<Field name="resolution">
{({ field }) => (
Expand All @@ -19,8 +22,4 @@ const KeepBothSection = ({ changeRadio }) => {
);
};

KeepBothSection.propTypes = {
changeRadio: PropTypes.func.isRequired,
};

export default KeepBothSection;
4 changes: 2 additions & 2 deletions ui/apps/platform/src/Containers/Policies/Modal/RenamePolicySection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import {
import { Field } from 'formik';

type RenamePolicySectionProps = {
changeRadio: (handler, name, value) => () => void;
changeText: (handler, name) => (_, value) => void;
changeRadio: (handler, name: string, value: string) => () => void;
changeText: (handler, name: string) => (_, value) => void;
};

const RenamePolicySection = ({ changeRadio, changeText }: RenamePolicySectionProps) => {
Expand Down
Loading