test(helm): cover extraction of pull secrets from the default SA#8964
test(helm): cover extraction of pull secrets from the default SA#8964
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
Images are ready for the commit at 22f8862. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8964 +/- ##
==========================================
- Coverage 47.29% 46.66% -0.63%
==========================================
Files 2431 2394 -37
Lines 165064 160018 -5046
==========================================
- Hits 78066 74675 -3391
+ Misses 80548 79122 -1426
+ Partials 6450 6221 -229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2606f5a to
d8304f4
Compare
d8304f4 to
22f8862
Compare
|
Not waiting for e2e tests, they are irrelevant to this change. |
Description
Now that we use a helmtest version with support for testing the
lookupfunction, add test coverage for extraction of pull secret names from the default service account.This was a warm-up for a fix to ROX-9156, but useful on its own.
Checklist
Evaluated and added CHANGELOG entry if requiredDetermined and documented upgrade stepsDocumented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)Testing Performed
Here I tell how I validated my change
CI is sufficient.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.