Closed
Conversation
This removes parts of stack lines related to the eval lines and columns. This was done this way to avoid breaking current stack traces until we have a good solution for including them.
Motivation: Focused specs, better ongoing support Modifications: Added jasmine and jasmine-core to package.json. Updated other dependencies.
…for polyfills. Release v1.3.3
…n-name-with-at-sign Fully parse function names with @ in Error.stack
Author
|
Is anything there stopping from merge? Locally all tests passed. |
Member
|
Sorry for the delay here. This change may break downstream libraries because they cannot construct Do you have any urgent need for this change? |
Author
|
Not really urgent need, just to do not have in client bundle them twice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.