Unify options to dir from directory for run and server confiuration#777
Merged
claymcleod merged 4 commits intostjude-rust-labs:mainfrom Mar 30, 2026
Merged
Unify options to dir from directory for run and server confiuration#777claymcleod merged 4 commits intostjude-rust-labs:mainfrom
dir from directory for run and server confiuration#777claymcleod merged 4 commits intostjude-rust-labs:mainfrom
Conversation
Serial-ATA
reviewed
Mar 30, 2026
Serial-ATA
approved these changes
Mar 30, 2026
claymcleod
approved these changes
Mar 30, 2026
Member
|
Thank you! |
claymcleod
added a commit
that referenced
this pull request
Mar 30, 2026
Merged
raman976
pushed a commit
to raman976/sprocket
that referenced
this pull request
Apr 6, 2026
raman976
pushed a commit
to raman976/sprocket
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #624
This pull request standardizes the naming of the output directory field in the server configuration from
output_directorytooutput_diracross the codebase, including configuration structs, defaults, command-line argument handling, and test files. This change improves consistency and reduces confusion when working with configuration options.Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate) docs: Unify output_dir naming in documentation sprocket.bio#41 .For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.