Skip to content

Unify options to dir from directory for run and server confiuration#777

Merged
claymcleod merged 4 commits intostjude-rust-labs:mainfrom
as1100k-forks:issue-624
Mar 30, 2026
Merged

Unify options to dir from directory for run and server confiuration#777
claymcleod merged 4 commits intostjude-rust-labs:mainfrom
as1100k-forks:issue-624

Conversation

@AS1100K
Copy link
Copy Markdown
Contributor

@AS1100K AS1100K commented Mar 28, 2026

Fixes #624

This pull request standardizes the naming of the output directory field in the server configuration from output_directory to output_dir across the codebase, including configuration structs, defaults, command-line argument handling, and test files. This change improves consistency and reduces confusion when working with configuration options.

Before submitting this PR, please make sure:

For external contributors:

  • You have read the contributing guide in its entirety.
  • You have not used AI on any parts of this pull request.
  • You have added a few sentences describing the PR here.
  • Your code builds clean without any errors or warnings.

For all contributors:

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

@AS1100K AS1100K marked this pull request as ready for review March 28, 2026 06:05
@AS1100K AS1100K requested a review from a team as a code owner March 28, 2026 06:05
@AS1100K AS1100K requested a review from peterhuene March 28, 2026 06:05
Comment thread CHANGELOG.md Outdated
@claymcleod
Copy link
Copy Markdown
Member

Thank you!

@claymcleod claymcleod merged commit 19a0a58 into stjude-rust-labs:main Mar 30, 2026
23 of 24 checks passed
claymcleod added a commit that referenced this pull request Mar 30, 2026
@sprocket-release-plz sprocket-release-plz Bot mentioned this pull request Mar 30, 2026
raman976 pushed a commit to raman976/sprocket that referenced this pull request Apr 6, 2026
raman976 pushed a commit to raman976/sprocket that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify options to either dir or directory for run and server`

3 participants