(feat): API handlers directly query database for read operations#779
Open
AS1100K wants to merge 9 commits intostjude-rust-labs:mainfrom
Open
(feat): API handlers directly query database for read operations#779AS1100K wants to merge 9 commits intostjude-rust-labs:mainfrom
AS1100K wants to merge 9 commits intostjude-rust-labs:mainfrom
Conversation
Remove the DbHandle wrapper and pass Arc<dyn Database> into AppState. Prune several unused RunManager commands and their unimplemented match arms/imports. Add a custom Debug impl for AppState.
Replace passing the raw query.limit Option with the resolved limit wrapped in Some(...) for runs, sessions, tasks and task logs calls so the query helpers always receive a concrete limit value. Also add a doc comment for AppState.db and a docstring for list_runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578
This PR updates the v1 API read handlers (runs/sessions/tasks) to query the
Databasedirectly viaAppStateinstead of going through theRunManagercommand channel.Read-only query logic has been moved into
system::v1::exec::queriesso it can be shared without coupling the API layer to the run manager service.No functional behavior changes are intended; responses, filtering, and pagination should remain the same.
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate).For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.