Fixes Unclosed json array stack overflow#373
Merged
stleary merged 1 commit intostleary:masterfrom Nov 3, 2017
Merged
Conversation
Corrects behavior of unclosed arrays
ee9e706 to
ed8745c
Compare
Contributor
Author
|
rebased against master |
Owner
|
How did a non-cyclical stackoverflow stay hidden in the code all these years? @agouz Thanks for catching this, and @johnjaylward thanks for the fix. Starting 3 day window. |
Contributor
Author
|
@stleary WTH was I thinking: throw new JSONException(x.syntaxError("Expected a ',' or ']'"));... that's wrong. should be: throw x.syntaxError("Expected a ',' or ']'"); |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
What problem does this code solve?
Fixes #372.
Risks
None. This is a bug fix and no functionality is changed.
Changes to the API?
none
Will this require a new release?
No. This bug fix only changes what exception is thrown in a syntax error. It does not change parsing of valid documents.
Should the documentation be updated?
No
Does it break the unit tests?
No. All unit tests should pass. New unit tests were created to verify the correct behavior. see stleary/JSON-Java-unit-test#80
Was any code refactored in this commit?
no
Review status
ACCEPTED Starting 3 day comment window