Skip to content

Pollish code#9

Merged
stmorgan merged 3 commits intostmorgan:masterfrom
TravisA9:master
Jan 10, 2018
Merged

Pollish code#9
stmorgan merged 3 commits intostmorgan:masterfrom
TravisA9:master

Conversation

@TravisA9
Copy link
Copy Markdown
Contributor

In keeping this as much to the original example as possible I went ahead and added a seed to the rand function. On the other hand, I used randn (normalised) instead of 2*rand(3,4) - 1 since this is something that's built in in julia and serves to simplify. I also took code out of global scope since that is strongly discouraged in julia due to the speed penalty imposed.

In keeping this as much like the original example as possible I went ahead and seeded the rand function. On the other hand, I used randn (normalised) instead since that is something that's built in in julia. I also took code out of global scope since that is highly discouraged in julia due to the speed penalty imposed.
@stmorgan stmorgan merged commit 2c5d374 into stmorgan:master Jan 10, 2018
@TravisA9
Copy link
Copy Markdown
Contributor Author

Hey @stmorgan, it looks like two files ended up getting pulled instead of just the one. The file I had intended to add/update was juliaVersion.jl I also created a place-holder file called juliaStyle.jl with the idea of eventually recreating this example but without following so closely to the video example. Of course that isn't done yet and I am not sure how much interest there will be in it so I didn't intend to add it. I will issue a pull request on some later date though just to put it out there for your consideration. Do you think it could be removed until then though? ...just to keep your project clean looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants