Skip to content

Lock sqlite version to fix global installation#326

Merged
superkhau merged 1 commit intomasterfrom
superkhau/lock-sqlite3-version
Oct 6, 2016
Merged

Lock sqlite version to fix global installation#326
superkhau merged 1 commit intomasterfrom
superkhau/lock-sqlite3-version

Conversation

@superkhau
Copy link
Copy Markdown
Contributor

@superkhau superkhau commented Oct 6, 2016

Connect to #325

* Newer versions of mapbox/node-sqlite3 are breaking API Connect and
  LoopBack installations

* Caused by 9a038b5 listing `node-pre-gyp` as a dep and installing it
  during `preinstall`

* See issue at TryGhost/node-sqlite3#720 for
  more details
@superkhau superkhau self-assigned this Oct 6, 2016
@superkhau superkhau added the #wip label Oct 6, 2016
@superkhau
Copy link
Copy Markdown
Contributor Author

superkhau commented Oct 6, 2016

@sam-github @davidcheung Taking over PR to get it landed quicker. Added in comments and reference to issue at mapbox. Review the additional comments please.

@sam-github
Copy link
Copy Markdown
Contributor

LGTM

@superkhau superkhau merged commit 829f6b2 into master Oct 6, 2016
@superkhau superkhau deleted the superkhau/lock-sqlite3-version branch October 6, 2016 20:06
@superkhau superkhau removed the #wip label Oct 6, 2016
@HenrikGr
Copy link
Copy Markdown

HenrikGr commented Oct 6, 2016

Is this fixed now? Have been waiting all evening. :-)

@dzonatan
Copy link
Copy Markdown

dzonatan commented Oct 6, 2016

New patch version is needed. Hopefully they publish it soon. ⌛️

superkhau pushed a commit that referenced this pull request Oct 6, 2016
 * Lock sqlite version to fix global installation (#326) (Simon Ho)
@superkhau
Copy link
Copy Markdown
Contributor Author

@HenrikGr @dzonatan Just published it now. 👍

@HenrikGr
Copy link
Copy Markdown

HenrikGr commented Oct 6, 2016

Thank you very much, is just to run npm install -g apiconnect again?

I have uninstalled everything, reinstalled node.js 4.5.0, upgraded NPM to 3.x.x and installed windows-build-tools.

@gunjpan
Copy link
Copy Markdown

gunjpan commented Oct 6, 2016

@HenrikGr : Yes, but first remove existing apiconnect, if any (just to have a clean install, IMO), using:
npm uninstall apiconnect -g and then install again.

@HenrikGr
Copy link
Copy Markdown

HenrikGr commented Oct 6, 2016

Hmm, got the same message, checked the npm-debug.log file and it says it tried to install [email protected].
I did delete npm and the npm-cache directory before installing reinstalling node.js and upgraded npm to 3.x.x.

I'm located in Sweden, could that play a part in it? :-)

I asking just becaus I try to learn.

@superkhau
Copy link
Copy Markdown
Contributor Author

@HenrikGr This is only for slc (npm install -g strongloop), we need to coordinate for apiconnect still, finding out if someone is on it now.

@superkhau
Copy link
Copy Markdown
Contributor Author

superkhau commented Oct 7, 2016

Upgrading strongloop/strongloop to sqlite3@^3.1.6 as we speak at #327

@superkhau
Copy link
Copy Markdown
Contributor Author

superkhau commented Oct 7, 2016

Landed #327, will go out with next release.

@HenrikGr
Copy link
Copy Markdown

HenrikGr commented Oct 7, 2016

God morning. Is it coordinated with apiconnect yet?

@superkhau
Copy link
Copy Markdown
Contributor Author

Morning, sqlite3 released a [fix to sqlite3@^3.1.6[(https://github.com/mapbox/node-sqlite3/commit/de2055b67196e95379c08b7405c39701559e3c25) which is automatically picked up by apiconnect, meaning it should work for you now.

@HenrikGr
Copy link
Copy Markdown

HenrikGr commented Oct 7, 2016

Thank you for all your help, appreciate it.

I could see it used version 3.1.6 now, but I got an error about to long file names/paths.

It seemed to be related to windows-build-tools. I need to do some further investigation.

@sam-github
Copy link
Copy Markdown
Contributor

@HenrikGr make sure you are using npm@3, it uses shorter paths by default, might clear the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants