forked from Yandex-Practicum/Java-Module-Project-YP
-
Notifications
You must be signed in to change notification settings - Fork 0
Проектная работа №1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
struklyts
wants to merge
4
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,48 @@ | ||
| import java.util.ArrayList; | ||
| import java.util.Scanner; | ||
|
|
||
| import main.java.Car; | ||
| import main.java.Race; | ||
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| System.out.println("Hello world!"); | ||
| ArrayList<Car> cars = getCars(3); | ||
| Race race = new Race(cars); | ||
| Car winner = race.getWinner(); | ||
| System.out.printf("Самая быстрая машина: %s", winner.title); | ||
| } | ||
|
|
||
| public static ArrayList<Car> getCars(int participantsCount) { | ||
| Scanner scanner = new Scanner(System.in); | ||
| ArrayList<Car> cars = new ArrayList<>(); | ||
| for (int i = 1; i <= participantsCount; i++) { | ||
| String title = getCarTitle(scanner, i); | ||
| int speed = getCarSpeed(scanner, i); | ||
| cars.add(new Car(title, speed)); | ||
| } | ||
|
|
||
| return cars; | ||
| } | ||
|
|
||
| public static String getCarTitle(Scanner scanner, int participantNumber) { | ||
| System.out.printf("— Введите название машины №%d:", participantNumber); | ||
| return scanner.next(); | ||
| } | ||
|
|
||
| public static int getCarSpeed(Scanner scanner, int participantNumber) { | ||
| System.out.printf("— Введите скорость машины №%d:", participantNumber); | ||
| if (!scanner.hasNextInt()) { | ||
| System.out.println("— Неправильная скорость"); | ||
| scanner.next(); | ||
| return getCarSpeed(scanner, participantNumber); | ||
| } | ||
|
|
||
| int speed = scanner.nextInt(); | ||
| if (Car.isSpeedValid(speed)) { | ||
| return speed; | ||
| } | ||
| System.out.println("— Неправильная скорость"); | ||
|
|
||
| return getCarSpeed(scanner, participantNumber); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package main.java; | ||
|
|
||
| public class Car { | ||
| final public String title; | ||
| final public int speed; | ||
|
|
||
| public Car(String title, int speed) { | ||
| this.title = title; | ||
| this.speed = speed; | ||
| } | ||
|
|
||
| public static boolean isSpeedValid(int speed) { | ||
| return speed > 0 && speed <= 250; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package main.java; | ||
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| public class Race { | ||
| private final ArrayList<Car> cars; | ||
| private Car winner; | ||
|
|
||
| public Race(ArrayList<Car> cars) { | ||
| this.cars = cars; | ||
| //тут надо кинуть екцепшен если машин меньше 2-х например, но мы их пока не изучали :-) | ||
| } | ||
|
|
||
| public Car getWinner() { | ||
| if (this.winner != null) { | ||
| return this.winner; | ||
| } | ||
|
|
||
| this.winner = cars.get(0); | ||
| for (Car car: cars) { | ||
| if (car.speed > winner.speed) { | ||
| this.winner = car; | ||
| } | ||
| } | ||
|
|
||
| return this.winner; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
От хранения массива машин и от этого цикла можно избавиться, запоминая победителя сразу при вводе, тем самым программа будет работать быстрее и требовать меньше памяти для выполнения
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ты имеешь ввиду перенести расчет победителя в конструктор? Не понимаю как избавиться от цикла: заменить на какой-то имеющийся метод сортировки который отсортирует список по одному из полей?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В целом конечно все можно написать короче и проще. Вопросы оптимизации конечно же важны в продакшене, при этом для меня сейчас важно пощупать и разобраться с синтаксисом, с подходами которые используются в java, поиспользовать структуры которые мы изучали и тп