feat(a11y): add accessibility improvements to layout and key pages#66
Open
nymulinfoinlet wants to merge 1 commit intomainfrom
Open
feat(a11y): add accessibility improvements to layout and key pages#66nymulinfoinlet wants to merge 1 commit intomainfrom
nymulinfoinlet wants to merge 1 commit intomainfrom
Conversation
Add skip-to-content link, ARIA labels on navigation and icon buttons, aria-current on active nav items, role=alert on error messages, aria-live on loading/streaming areas, focus-visible global outline, semantic HTML roles on header/main/sidebar. Covers DashboardLayout, DashboardHomePage, QuizPage, and ReviewQueuePage. Resolves #54. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-current="page"on active nav,aria-labelon icon-only buttons (sidebar close, menu toggle, user menu),aria-expanded/aria-haspopupon dropdowns,role="menu"/role="menuitem"on user dropdownrole="alert"on error messages (QuizPage),aria-live="polite"on loading/streaming areas (QuizPage generating screen, ReviewQueuePage loading/explanation)aria-hidden="true"on decorative Lucide icons throughout layout, dashboard, quiz, and review pages*:focus-visibleoutline style (2px solid #2563eb) for keyboard navigation visibilityrole="banner"on header,role="main"withid="main-content"on content areaResolves #54
Test plan
🤖 Generated with Claude Code