Open
Conversation
Create an anagram checker in the required assignment notebook. Additionally, adds various checks in the notebook at the end for the array of anagrams, as per assignment instructions
Leaves a note deprecating part 3 of the assignment as it was removed from the assignment in a PR post fork. Describes why it was left up in the markdown doc as well. Additionally, update some of the comments+ add docstrings to the methods explaining the use of dicts instead of a sorted string.
juliagallucci
approved these changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Good! Your code executes without error and is well commented. One note, try to make code as concise as possible; for example Part A could be written in 2 lines
def anagram_checker(word_a, word_b):
return sorted(word_a.lower()) == sorted(word_b.lower())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Create an anagram checker in the required assignment notebook. Additionally, adds various checks in the notebook at the end for the array of anagrams, as per assignment instructions
What did you learn from the changes you have made?
set(), otherwise you get a dictWas there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Not really.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Solving the array of anagrams problem means you can't use dicts, because you need to hash the dict output. That led me down to use sets instead of dicts. That was fun.
How were these changes tested?
notebook args.
A reference to a related issue in your repository (if applicable)
N/A
Checklist