chore: update to symfony 6#172
Merged
bytestream merged 4 commits intosupportpal:masterfrom Mar 5, 2023
Merged
Conversation
Contributor
Author
|
FYI: we currently use the fork on our test environment and have not seen any issues. The things we do are:
I have not found any issues with it. |
bytestream
requested changes
Mar 3, 2023
Member
bytestream
left a comment
There was a problem hiding this comment.
Unfortunately I think we need to maintain PHP 7.2+ support.
Contributor
Author
|
Fair enough. It's not something I considered as 7.2 has been EOL for so long. I will look at it this weekend and commit the suggested changes. |
Co-authored-by: Kieran <[email protected]>
Co-authored-by: Kieran <[email protected]>
Contributor
Author
|
It should be good to go now. |
bytestream
approved these changes
Mar 5, 2023
Member
|
Thanks @ju5t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're in the progress of upgrading our application to Laravel 10 and as such, require Symfony 6. This also switches two interfaces as the previous ones are deprecated by Symfony. The return type was a requirement as well. Without it, phpunit wouldn't pass.
Note: in my local environment E2E tests were failing, also for the main branch.