Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Swift Package Manager support#441

Closed
igorcamilo wants to merge 2 commits intoswisspol:masterfrom
igorcamilo:master
Closed

Swift Package Manager support#441
igorcamilo wants to merge 2 commits intoswisspol:masterfrom
igorcamilo:master

Conversation

@igorcamilo
Copy link
Copy Markdown

@igorcamilo igorcamilo commented Oct 8, 2019

Adds SwiftPM support to the core part of the library.

Rationale

  1. In order to support all package managers, I had to make significant changes to the folder structure:
    1. Code is in Sources/<Target Name> and the public headers are in Sources/<Target Name>/include, as SwiftPM expects.
    2. Unlike Carthage and CocoaPods, SwiftPM doesn't flatten the folder structure at compile time, so imports like #import "GCDWebServer.h" would have to be #import "../Core/GCDWebServer.h. Thats why I just moved them all to a single folder.
  2. GCDWebDavServer couldn't compile because it requires a specific header search path. SwiftPM does in fact support this parameter but I couldn't get it working.
  3. GCDWebUploader has a bundle, which is not currently supported by SwiftPM.

@igorcamilo igorcamilo marked this pull request as ready for review October 8, 2019 09:06
@swisspol
Copy link
Copy Markdown
Owner

swisspol commented Oct 9, 2019

Thanks for sending this in but this is not something I can merge at this time. The risk of breaking something is high while the benefits are low (SPM is not used much and GCDWebUploader would. It work if bundle is missing).

@swisspol swisspol closed this Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants