Skip to content

UofT-DSI | Python - Assignment 1#1

Merged
syn-namon merged 2 commits intomainfrom
assignment-1
May 7, 2025
Merged

UofT-DSI | Python - Assignment 1#1
syn-namon merged 2 commits intomainfrom
assignment-1

Conversation

@syn-namon
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I am adding code to both sections of the 1st assignment.

What did you learn from the changes you have made?

I have learned how to create functions using multiple tools:

  • strings, methods and functions which can operate with it;
  • better understanding of loops and dictionaries;
  • how to operate and compare lists;
  • operator if - else and elif;
  • return, input and output.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Yes, I have added it to my code as an alternative (function anagram_chaker1).

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I had a little challenge understanding the role of the third variable, is_case_sensitive, but when I started typing my questions in Slack, I eventually figured it out.
I also had some challenges with understanding the logic of loops and returns. I've already found my answers.

How were these changes tested?

First, locally in a separate file.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • I can confirm that my changes are working as intended.
  • I created a branch with the correct naming convention.
  • I ensured that the repository is public.
  • I reviewed the PR description guidelines and adhered to them.
  • I verify that the link is accessible in a private browser window.

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is functional, but it could be simplified using fewer lines with sorted() and string methods. Please revise

@syn-namon
Copy link
Copy Markdown
Owner Author

@juliagallucci hi! I have committed the requested changes. could you please review?
thank you!

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. One note for improvement, no need for if/else statements in instances like sorted(word_a_clean) == sorted(word_b_clean); this already returns a boolean!

@syn-namon
Copy link
Copy Markdown
Owner Author

@juliagallucci oh, I see. thank you for the advice!!

@syn-namon syn-namon closed this May 7, 2025
@syn-namon syn-namon reopened this May 7, 2025
@syn-namon syn-namon merged commit 5450adb into main May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants