🐛 Fix admin status filter "All" option always reverting to "Active"#1239
Merged
0x46616c6b merged 1 commit intomainfrom Apr 13, 2026
Merged
🐛 Fix admin status filter "All" option always reverting to "Active"#12390x46616c6b merged 1 commit intomainfrom
0x46616c6b merged 1 commit intomainfrom
Conversation
The "All" option in the deleted-status dropdown for user and alias admin lists omitted the deleted parameter from the URL entirely. Since the controller defaults to "active" when the parameter is absent, selecting "All" behaved identically to "Active" and deleted entries were never shown. Send deleted=all explicitly so the repositories skip the deleted filter, and update the extra_params filters to treat "all" as a default value alongside "active". Co-Authored-By: OpenCode <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "All" option in the status filter dropdown on the admin user and alias list pages did not work — selecting it always reverted to "Active", making it impossible to view deleted entries or all entries together.
Root Cause
The "All"
<option>omitted thedeletedquery parameter from the URL entirely. Since the controller defaults to'active'when the parameter is absent ($request->query->getString('deleted', 'active')), selecting "All" was indistinguishable from selecting "Active". Additionally, theselectedcheck (deleted == '') could never be true because the controller always provided at least'active'.Fix
deleted=allexplicitly in the "All" option URL (instead of omitting the parameter)selectedcheck fromdeleted == ''todeleted == 'all'extra_paramsfilters to treat'all'as a default value alongside'active'(so it doesn't appear as a redundant query parameter in search/pagination URLs)No backend changes were needed — the repositories already handle unknown
deletedvalues by skipping the filter (only'active'and'deleted'add a WHERE clause).The changes and the PR were generated by OpenCode.