Reviving Lee's Refresh now#250
Merged
graysonarts merged 8 commits intotableau:developmentfrom Jan 15, 2018
graysonarts:refresh-now
Merged
Reviving Lee's Refresh now#250graysonarts merged 8 commits intotableau:developmentfrom graysonarts:refresh-now
graysonarts merged 8 commits intotableau:developmentfrom
graysonarts:refresh-now
Conversation
t8y8
suggested changes
Jan 15, 2018
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
Do we already have test coverage on this?
| all_tasks_xml = parsed_response.findall( | ||
| './/t:job', namespaces=ns) | ||
|
|
||
| all_tasks = (JobItem._parse_element(x, ns) for x in all_tasks_xml) |
Collaborator
There was a problem hiding this comment.
Nit: You can just do a list comprehension since you just convert to a lista line later.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been an outstanding change for refresh now for a while. This is to finally get this into the code base.