Refactor the refresh sample to be more explicit#288
Merged
graysonarts merged 1 commit intotableau:developmentfrom Apr 17, 2018
graysonarts:make_refresh_sample_clear
Merged
Refactor the refresh sample to be more explicit#288graysonarts merged 1 commit intotableau:developmentfrom graysonarts:make_refresh_sample_clear
graysonarts merged 1 commit intotableau:developmentfrom
graysonarts:make_refresh_sample_clear
Conversation
LGraber
approved these changes
Apr 17, 2018
Contributor
LGraber
left a comment
There was a problem hiding this comment.
Given that you have the resource_id, you could just contruct the object and pass it in. I don't remember why I took the object and not the id here. We should be more consistent. Oh well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.