Skip to content

Assignment 1 and 2#1

Open
tejinder-gh wants to merge 2 commits intomainfrom
assignment-two
Open

Assignment 1 and 2#1
tejinder-gh wants to merge 2 commits intomainfrom
assignment-two

Conversation

@tejinder-gh
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@l-mack l-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the following points and resubmit to complete your assignment 2:

Your assignment 2 pull request should only include changes for assignment_2.ipynb. Your pull request includes several files that are not related assignment. There are a few ways you. could correct this, one approach is to create a new branch from main (call it assignment_2 and ensure main branch is clean) and only submit your changes for assignment_2.ipynb.

@tejinder-gh
Copy link
Copy Markdown
Owner Author

i have removed the extra files from this branch Laura,
this branch contains content of assignment-1 and assignment-2. I tried to revert the files from subsequent assignments and put them only in their subsequent branches respectively, but while copying the content, it only provided JSON like structure for notebook files, so I decided to check if this time you can accomodate both assignments in single branch, and for further assignments, we will have in correct format.

@l-mack
Copy link
Copy Markdown

l-mack commented May 23, 2025

@tejinder-gh I have marked your assignment 2 as complete, please in future only include files relevant to the assignment in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants