ETag must be an exact match#826
Closed
da2x wants to merge 1 commit intotextpattern:devfrom
da2x:bugfix_feed_etag_validation
Closed
ETag must be an exact match#826da2x wants to merge 1 commit intotextpattern:devfrom da2x:bugfix_feed_etag_validation
da2x wants to merge 1 commit intotextpattern:devfrom
da2x:bugfix_feed_etag_validation
Conversation
Member
|
What was the original reason for |
Contributor
Author
A bug. I can’t find any historical reason for this in older revisions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes these issues:
rss_how_manysetting is increased. (Or a?limit=valueis masked and increased through mod_rewrite.)"-<encoding>"suffix to etags (e.g.ETag: "etagvalue-gzip") when it’s been processed through an encoding output filter for which Textpattern shouldn’t reply 304. Breaks caching when two non-equivalent resources (different encodings) report to have the same ETag.You can see the headers not updating in response to content negotiation here: https://redbot.org/?uri=http%3A%2F%2Ftextpattern.com%2Fatom%2F%3Fsection%3Dweblog (or see a snapshot from archive.org if you’re from the future.)