Merged
Conversation
b220109 to
381602e
Compare
This feature required using dynamic `import()` which threw Webpack for a a loop, and also was a potential security risk. We now have the ability to extend the list of global symbols when you create the PlatformScript interpreter. That is the point at which you can define any global functions you want, which can then be referenced by your PS modules. So this feature is not needed and is being removed.
381602e to
114620d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This feature required using dynamic
import()which threw Webpack for a a loop, and also was a potential security risk.Approach
We now have the ability to extend the list of global symbols when you create the PlatformScript interpreter. That is the point at which you can define any global functions you want, which can then be referenced by your PS modules. So this feature is not needed and is being removed.