Add ability to evaluate a value as a PlatformScript module.#29
Merged
Conversation
81e9d95 to
ede5e6b
Compare
Sometimes we want to be able to treat a snippet of code as a fully formed module that can depend on other modules and define symbols. There is a bit of a risk in the sense of what do you do if you have two different virtual modules that have the same URL? This should probably be an error.
ede5e6b to
20e28f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we want to be able to treat a snippet of code as a fully formed module that can depend on other modules and define symbols.
There is a bit of a risk in the sense of what do you do if you have two different virtual modules that have the same URL? This should probably be an error.
Approach
This adds a
moduleEvaloperation to PlatformScript to treat any PlatformScript value as a module.Alternate Designs
We can in the future just make
$importa function that is defined everywhere and the result is that it just returns a module. This can be explored later.