Skip to content

fix issue 261#262

Closed
gongqingkui wants to merge 0 commit intotheskumar:masterfrom
gongqingkui:master
Closed

fix issue 261#262
gongqingkui wants to merge 0 commit intotheskumar:masterfrom
gongqingkui:master

Conversation

@gongqingkui
Copy link
Copy Markdown

@gongqingkui gongqingkui commented Jul 4, 2020

fix issue 261

X;\venv\lib\site-packages\dotenv\parser.py", line 44, in("string", typing.Text),
AttributeError: module 'typing' has no attribute 'Text'

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.806% when pulling 264c51f on gongqingkui:master into e4bbb8a on theskumar:master.

@bbc2
Copy link
Copy Markdown
Collaborator

bbc2 commented Jul 16, 2020

Sorry I pushed the wrong commit to your branch and that closed this pull request, preventing me from fixing your branch. I opened a new pull request (#267) where I replaced the except Exception by except (ImportError, AttributeError) because I think that's better (otherwise, it could hide unrelated problems). You can let me know what you think.

@gongqingkui
Copy link
Copy Markdown
Author

Yeah,it's a good way to resolve this question.I didn't writed it although I have thinking of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants