Audio: Continue volume ramp until all channels are complete#3450
Merged
Audio: Continue volume ramp until all channels are complete#3450
Conversation
Collaborator
Author
|
SOFCI TEST |
The volume component works correct when all channels receive the same gain value in volume set command. This patch fixes a bug that is triggered by applying different gain values for the channels. The logic with setting cd->ramp_finished to true caused the check in volume copy() to no more call volume_ramp() when one of the channel reached their target volume. When the ramp updating was stopped all other channels remain in intermediate gain value. In the fix the logic is set to opposite. Whenever a channel needs a ramp update it sets a temporary flag. The ramp finish is set only when no channels needed gain update. Fixes #3455 Signed-off-by: Seppo Ingalsuo <[email protected]>
31ed433 to
fb19e7f
Compare
lgirdwood
approved these changes
Sep 23, 2020
Member
|
@singalsu can you check CI |
Member
Collaborator
Author
|
There were not these fails with the previous [RFC] version of the patch. I recall there was one BSW fail that should be unrelated. |
Member
|
Passing now, must have been a CI issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume component works correct when all channels receive the same
gain value in volume set command.
This patch fixes a bug that is triggered by applying different
gain values for the channels. The logic with setting cd->ramp_finished
to true caused the check in volume copy() to no more call volume_ramp()
when one of the channel reached their target volume. When the ramp
updating was stopped all other channels remain in intermediate gain
value.
In the fix the logic is set to opposite. Whenever a channel needs a ramp
update it sets a temporary flag. The ramp finish is set only when
no channels needed gain update.
Fixes #3455
Signed-off-by: Seppo Ingalsuo [email protected]