Skip to content

repo, signer: Pin securesystemslib better#243

Merged
jku merged 1 commit intotheupdateframework:mainfrom
jku:fix-securesystemslib-pinning
Apr 3, 2024
Merged

repo, signer: Pin securesystemslib better#243
jku merged 1 commit intotheupdateframework:mainfrom
jku:fix-securesystemslib-pinning

Conversation

@jku
Copy link
Copy Markdown
Member

@jku jku commented Apr 3, 2024

Securesystemslib is "pre 1.0" so the normal pinning does not really work: the new pinning "~= 0.31.0" should lead to 0.31.1 to be accepted but not 0.32.0.

Securesystemslib is "pre 1.0" so the normal pinning does not
really work: the new pinning "~= 0.31.0" should lead to
0.31.1 to be accepted but not 0.32.0.
@jku jku requested a review from lukpueh April 3, 2024 12:22
Copy link
Copy Markdown
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs this means >= 0.31.0, == 0.31.*, which makes sense.

LGTM

@jku jku merged commit 551e5f1 into theupdateframework:main Apr 3, 2024
lukpueh pushed a commit to lukpueh/in-toto that referenced this pull request Apr 3, 2024
There are several breaking changes coming up in securesystemslib on its
way to 1.0.

To not disrupt in-toto users this patch pins securesystemslib to its
current minor version.

This is similar to what python-tuf and tuf-on-ci do:
- theupdateframework/python-tuf#2600
- theupdateframework/tuf-on-ci#243

Signed-off-by: Lukas Puehringer <[email protected]>
@jku jku mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants